790 ransack clear filters #936
Open
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorSimash
changed the title
loqimean
approved these changes
Nov 4, 2024
Co-authored-by: Ivan Marynych <[email protected]>
KseniaGovorun
approved these changes
Nov 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #936 +/- ##
========================================
Coverage 91.16% 91.16%
========================================
Files 70 70
Lines 973 973
========================================
Hits 887 887
Misses 86 86 ☔ View full report in Codecov by Sentry. |
loqimean
force-pushed
the
develop
branch
4 times, most recently
from
03a3caf
to
7d2dc81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #790
Code reviewers
Summary of issue
There is no logic to clear filters in account/calculators, categories, products etc. pages.
Summary of change
Added button to ransack form that links user to clear (without any filters) page.
CHECK LIST